Skip to content

Add completion for mech-dump #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add completion for mech-dump #1452

wants to merge 1 commit into from

Conversation

@mikkoi
Copy link

@mikkoi mikkoi commented Oct 4, 2025 

Part of WWW-Mechanize Perl distribution https://github.com/libwww-perl/WWW-Mechanize
WWW::Mechanize, or Mech for short, is a Perl module
for stateful programmatic web browsing, used for automating interaction with websites.

GitHub Issue https://github.com/scop/bash-completion/issues/474

@akinomyoga
Copy link
Collaborator

Please read CONTRIBUTING.md before submitting a PR.

The same completion seems to have been submitted to the upstream at libwww-perl/WWW-Mechanize#396, but the upstream hasn't yet rejected including the completion settings in their project.

This contains a hardcoded list of the options, though the options seem to be able to be extracted from the --help output.

The completion functions don't follow the naming convention at all.

The bundled completion doesn't need to anticipate that utilities bash-completion provides (such as _init_completion) are not available.

@akinomyoga akinomyoga mentioned this pull request Oct 4, 2025
Open
@mikkoi
feat(mech-dump): Add completion to mech-dump
4cf43bb 
    Part of WWW-Mechanize Perl distribution
    https://github.com/libwww-perl/WWW-Mechanize
    WWW::Mechanize, or Mech for short, is a Perl module for stateful
    programmatic web browsing, used for automating interaction with websites.

    GitHub Issue scop#474
@mikkoi mikkoi force-pushed the add-completion-mech-dump branch from 6280e42 to 4cf43bb Compare October 19, 2025 18:32
@mikkoi
Copy link
Author

mikkoi commented Oct 19, 2025

Upstream PR merged and closed: libwww-perl/WWW-Mechanize#396

I have updated this PR with the same. Now following the conventions.
Please tell me, if something doesn't match.

@mikkoi
Copy link
Author

mikkoi commented Oct 19, 2025

I would appreciate if you could attach the label "hacktoberfest-accepted" to this PR.

@akinomyoga
Copy link
Collaborator

As the upstream ships the completion file, we wouldn't host the file.

@akinomyoga akinomyoga closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ask upstream project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikkoi @akinomyoga